linyunanit commented on PR #15332: URL: https://github.com/apache/lucene/pull/15332#issuecomment-3398313234
> I'm sorry this comes in multiple requests. Could we also rename the issue and changes entry to make it clear to people as to what's changed? I'd suggest "Add PhraseQuery.Builder.setMaxTerms() method to limit the maximum number of terms and excessive memory use." > > I would also rename the method accordingly and add javadocs to it that say what happens when you exceed the threshold (IllegalArgumentException is thrown). Thank you. Thanks for the review, @dweiss! Great suggestions. I've made the following changes: 1. **Renamed the method**: Changed `setTermThreshold(int value)` to `setMaxTerms(int maxTerms)` as suggested. 2. **Updated Javadoc**: Added clear documentation explaining that `IllegalArgumentException` is thrown when the threshold is exceeded. 3. **Updated the issue/changes entry**: Modified to make it clear to people as to what's changed. Looking forward to getting this merged! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
