msokolov commented on code in PR #15294:
URL: https://github.com/apache/lucene/pull/15294#discussion_r2461073484
##########
lucene/core/src/test/org/apache/lucene/internal/vectorization/TestVectorizationProvider.java:
##########
@@ -24,6 +24,10 @@ public void testCallerOfGetter() {
expectThrows(UnsupportedOperationException.class,
TestVectorizationProvider::illegalCaller);
}
+ public void testGetProviderName() {
+ assertEquals("DefaultVectorizationProvider",
VectorizationProvider.getImplementationName());
Review Comment:
Yeah I'm not clear how we are testing the Panama support -- we must be! I
also get confused about whether the incubating flag is required - some Paname
stuff finally came out of incubator? But I guess the Vector API is still in it
and will be forever. But anyway we must somewhere be running tests with
incubus unleashed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
