jainankitk commented on code in PR #15383:
URL: https://github.com/apache/lucene/pull/15383#discussion_r2488344246
##########
lucene/core/src/java/org/apache/lucene/util/DocIdSetBuilder.java:
##########
@@ -41,7 +41,11 @@ public final class DocIdSetBuilder {
*
* @see DocIdSetBuilder#grow
*/
- public sealed interface BulkAdder permits FixedBitSetAdder, BufferAdder {
+ public sealed interface BulkAdder
+ permits FixedBitSetAdder,
+ BufferAdder,
+ PartitionAwareFixedBitSetAdder,
+ PartitionAwareBufferAdder {
Review Comment:
That's a good point. We should run the benchmark to quantify the impact due
to virtual calls and megamorphism. Also assuming the impact is significant, I
am wondering if we can use directly `PartitionAwareFixedBitSetAdder` instead of
`FixedBitSetAdder`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
