jainankitk commented on code in PR #15409:
URL: https://github.com/apache/lucene/pull/15409#discussion_r2501756317
##########
.github/workflows/verify-changelog-and-set-milestone.yml:
##########
@@ -57,8 +57,7 @@ jobs:
echo "Diff:"
if git diff --exit-code --name-only "$BASE_COMMIT" HEAD --
"$CHANGE_LOG_FILE"; then
echo "Change log file:$CHANGE_LOG_FILE does not contains an entry
corresponding to changes introduced in PR. Please add a changelog entry."
- gh pr comment "$PR_NUMBER" --body "This PR does not have an entry
in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog
entry, then add the skip-changelog label to it and you will stop receiving this
reminder on future updates to the PR."
- exit 0
+ exit 1
Review Comment:
Sorry, I am slightly confused. Wouldn't this warning message get logged into
the github workflow log? We should still fail the workflow, so that the
committer is reminded that PR is missing changelog entry. They can then chose
to:
* Ignore the failure and merge the PR
* Add skip-changelog label, let the workflow succeed and merge the PR
* Get changelog entry added before merging the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
