jainankitk commented on code in PR #15409:
URL: https://github.com/apache/lucene/pull/15409#discussion_r2512085988
##########
.github/workflows/verify-changelog-and-set-milestone.yml:
##########
@@ -57,8 +57,7 @@ jobs:
echo "Diff:"
if git diff --exit-code --name-only "$BASE_COMMIT" HEAD --
"$CHANGE_LOG_FILE"; then
echo "Change log file:$CHANGE_LOG_FILE does not contains an entry
corresponding to changes introduced in PR. Please add a changelog entry."
- gh pr comment "$PR_NUMBER" --body "This PR does not have an entry
in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog
entry, then add the skip-changelog label to it and you will stop receiving this
reminder on future updates to the PR."
- exit 0
+ exit 1
Review Comment:
Okay, I tried both the versions by raising couple of PRs on my fork:
* On the version with warning, I could see it [only in the
log](https://github.com/jainankitk/lucene/actions/runs/19247193779/job/55023958339?pr=3)
without any indication on the PR itself -
https://github.com/jainankitk/lucene/pull/3
* The other version clearing failed the specific step which I feel is
clearer IMO - https://github.com/jainankitk/lucene/pull/2
Hence, my preference is still the latter. Although, we should log the
message with error annotation before failing the workflow. Please let me know
what you think about that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
