dsmiley commented on code in PR #15436:
URL: https://github.com/apache/lucene/pull/15436#discussion_r2546287636
##########
lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java:
##########
@@ -799,6 +799,16 @@ protected void search(LeafReaderContextPartition[]
partitions, Weight weight, Co
collector.setWeight(weight);
+ if (collector.scoreMode().isExhaustive() == false) {
+ Comparator<LeafReaderContext> leafComparator =
collector.getLeafReaderComparator();
Review Comment:
Perhaps we shouldn't gate this here by isExhaustive. Maybe let the
Collector author decide when to return non-null. It keeps IndexSearcher logic
simpler, removing a non-obvious condition to the uninitiated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
