mikemccand commented on PR #15415: URL: https://github.com/apache/lucene/pull/15415#issuecomment-3606874002
> Looking good! I am sorry we missed this with the new format. Thank you for taking care of it. No worries, Codecs are hard enough, and the [gains for 4-bit and 8-bit from OSQ](https://github.com/apache/lucene/pull/15169) are awesome. I think there was also a testing gap -- "normally" we would put cross-Codec-impl expectations as test methods in `BaseKnnVectorsFormatTestCase` class, I think? This way, a new Codec's (`KnnVectorsFormat`) test class would extend that base class and see test failures if that capability broke? But I guess it's tricky for this feature, since it's conditional on quantization and needs specific Codec setup. Did this PR try to address the test gap? If we lose "rehydrate from quantized vectors only", will any tests now fail? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
