dweiss commented on PR #15508:
URL: https://github.com/apache/lucene/pull/15508#issuecomment-3668692297
I looked again and I still think a nicer way to plug this native impl. into
Lucene would be to make another implementation of VectorUtilSupport
("NativeVectorUtilSupport") and then use it instead of the default Panama
implementation, if it is available. If you used service lookup for picking the
implementation, you could select between them when classes are initialized.
Then the native implementation could go into its own module and there'd be no
need for hacks like system properties, internals opened for benchmarks, etc.
I may be missing something of course, but I think it'd be a much easier way
forward. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
