shubhamvishu commented on PR #15508: URL: https://github.com/apache/lucene/pull/15508#issuecomment-3673651373
@dweiss I tried to make it more pluggable and added the `NativeVectorUtilSupport` which let users opt-in to use native binaries on the fly without doing anything extra. If there is library present and also have the required implementation it automatically switches to native implementation or else fallback to Panama based implementation. So nothing changes for users who don't want to use or try it(they would continue using `PanamaVectorUtilSupport` basically). I removed all the gradle related changes and not generate any binary at all for now. To to test a user could just simply : ``` // Passes ./gradlew test ./gradlew test -Ptest.native.dotProduct=false ./gradlew test -Ptest.native.dotProduct=true -Ptests.jvmargs="-Djava.library.path=/home/simd" ./gradlew test -Ptests.jvmargs="-Dlucene.useNativeDotProduct=true -Djava.library.path=/home/simd" // Fails ./gradlew test -Ptests.jvmargs="-Dlucene.useNativeDotProduct=true" ./gradlew test -Ptest.native.dotProduct=true ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
