shubhamsrkdev opened a new pull request, #15610:
URL: https://github.com/apache/lucene/pull/15610

   ### Problem
   After merging #15295 some nightly tests started failing. @romseygeek 
reported the following:
   
   ```
   TestLucene87StoredFieldsFormatHighCompression > testMergeStability FAILED
   --
   java.lang.AssertionError: expected:<{fnm=77, fdt=37004, fdx=64, fdm=159}> 
but was:<{cfs=37366, cfe=150}>
   at __randomizedtesting.SeedInfo.seed([DF7E25E7C981E11B:AB3263C8C46BE3AD]:0)
   at [email protected]/org.junit.Assert.fail(Assert.java:89)
   at [email protected]/org.junit.Assert.failNotEquals(Assert.java:835)
   at [email protected]/org.junit.Assert.assertEquals(Assert.java:120)
   at [email protected]/org.junit.Assert.assertEquals(Assert.java:146)
   at 
[email protected]/org.apache.lucene.tests.index.BaseIndexFileFormatTestCase.testMergeStability(BaseIndexFileFormatTestCase.java:306)
   ```
   
   ### Solution
   There are two solutions I can think of:
   
   - We can modify `Lucene87RWCodec` to cache compoundFormat like 
`Lucene94Codec`:
   
   ```
     public final CompoundFormat compoundFormat() {
       return compoundFormat;
     }
   ```
   
   - We can stop disabling CFS explicitly in this test (leave the default as 
is). 
   
   I am going with the second one as we don't want to change existing codecs.
   
   ### Testing
   
   ```
   ./gradlew test --tests 
TestLucene87StoredFieldsFormatHighCompression.testMergeStability 
-Dtests.seed=DF7E25E7C981E11B -Dtests.nightly=true -Dtests.locale=ig-Latn-NG 
-Dtests.timezone=Asia/Qostanay -Dtests.asserts=true -Dtests.file.encoding=UTF-8
   ```
   Passes
   
   ```
   ./gradlew test   -Dtests.nightly=true -Dtests.locale=ig-Latn-NG 
-Dtests.timezone=Asia/Qostanay -Dtests.asserts=true -Dtests.file.encoding=UTF-8
   ```
   TK - Still running, will update


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to