mikemccand commented on PR #15610: URL: https://github.com/apache/lucene/pull/15610#issuecomment-3804684134
> On second thought, after seeing #15616, I'm worried we're making a riskier change to the conditions the tests were running under in this PR than in #15616. +1 It looks like this PR is removing the "don't use compound file" from `testMergeStability`? That does seem a bit dangerous -- does this test somehow rely on this, e.g. need to see individual index files (that would be hidden away inside CFS)? Was that added separately (after the test was originally created, for a specific reason / test failure)? Maybe do some digital archaeology to see why it disabled CFS? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
