iverase opened a new pull request, #15732: URL: https://github.com/apache/lucene/pull/15732
This PR is just addressing the following suggestion from Adrien when merging https://github.com/apache/lucene/pull/601#discussion_r783711025. This version only supports un-quantised vectors because for quantise vectors the logic is a bit more complex (it depends if the quantisation is symmetric or not) so I leave it as a follow up. The key aspects of this implementation are: 1.- KnnVectorsWriter#mergeOneField returns now an IORunnable. The merge is done in two steps, first we call this method for the fields collecting the IORunnables. After calling of the fields we iterate over the runnables and execute them. 2.- Introduce a new interface QuantizedVectorsWriter to signal if the field requires quantised vectors for merging. We move the method #mergeOneFieldToIndex from FlatVectorsWriter to this new interface. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
