msokolov commented on PR #15732: URL: https://github.com/apache/lucene/pull/15732#issuecomment-3935980074
I guess the flip side is now we have added the ability to defer some unspecified work to a second phase, but maybe we will not need it in the future? I guess it's a matter of opinion, but for me, I'd like to avoid abstractions we don't absolutely need. Also, adding the abstraction opens up questions like what if we have more than two phases (in the future)? Like we want to first compute centroids, then merge the flat vectors, then build some indexing structures, I don't know; in that case we should have a an IOCallable that returns an IOCallable so we can chain them? Obviously it's overkill now. Anyway if you wouldn't mind trying the concrete implementation I think it will be easier to understand. If it looks bad to you, OK, this way works and I won't block it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
