iverase commented on code in PR #15732:
URL: https://github.com/apache/lucene/pull/15732#discussion_r2931647462


##########
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene102/Lucene102BinaryQuantizedVectorsReader.java:
##########
@@ -342,6 +358,107 @@ private FieldEntry readField(IndexInput input, FieldInfo 
info) throws IOExceptio
     return FieldEntry.create(input, vectorEncoding, 
info.getVectorSimilarityFunction());
   }
 
+  @Override
+  public BaseQuantizedByteVectorValues getQuantizedVectorValues(String 
fieldName) {
+    return null;
+  }
+
+  @Override
+  public ScalarQuantizer getQuantizationState(String fieldName) {
+    return null;
+  }
+
+  @Override
+  public CloseableRandomVectorScorerSupplier 
getRandomVectorScorerSupplierForMerge(

Review Comment:
   It is used by the writer in the test folder for merging segments.



##########
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene99/Lucene99ScalarQuantizedVectorsReader.java:
##########
@@ -348,6 +350,18 @@ public ScalarQuantizer getQuantizationState(String field) {
     return fieldEntry.scalarQuantizer;
   }
 
+  @Override
+  public CloseableRandomVectorScorerSupplier 
getRandomVectorScorerSupplierForMerge(

Review Comment:
   It is used by the writer in the test folder for merging segments.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to