sgup432 commented on issue #15816: URL: https://github.com/apache/lucene/issues/15816#issuecomment-4071288834
While doing some digging in this similarity-based vector query test, it is not guaranteed to return the exact live docs considering deletes can create disconnected graphs. As @kaivalnp mentioned, having `traversalSimilarity = Float.NEGATIVE_INFINITY` should do a force brute-force search. Seems like we have two paths forward: 1. Either we change the assertion `assertEquals(numDocs - endIndex + startIndex - 1, scoreDocs.length);` to `assertThat(scoreDocs.length, lessThanOrEqualTo(expectedLiveDocs))` ie do an approximate match and accept we can't always return exact doc count. **OR** 2. We change/fix the logic in query itself to do an exact match when `traversalSimilarity = Float.NEGATIVE_INFINITY`. The latter approach might be the right way to go about it IMO. @kaivalnp Thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
