iprithv commented on code in PR #16069:
URL: https://github.com/apache/lucene/pull/16069#discussion_r3287021771
##########
lucene/core/src/java/org/apache/lucene/search/MaxScoreBulkScorer.java:
##########
@@ -184,6 +188,40 @@ private void scoreInnerWindowWithFilter(
int innerWindowMax = MathUtil.unsignedMin(max, innerWindowMin +
INNER_WINDOW_SIZE);
docAndScoreAccBuffer.size = 0;
+ if (filterMatches == null) {
+ fillScoreBufferViaLeapFrog(top, acceptDocs, innerWindowMax);
+ } else {
+ fillScoreBufferViaBitSet(top, acceptDocs, innerWindowMax);
Review Comment:
yeah right, the existing filter tests use a sparse filter (cost=4 vs
threshold=768) so the bitset path is never exercised. Added two tests, both
assert that the filter density exceeds the threshold so we know the bitset path
is actually taken. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
