gaobinlong commented on code in PR #15936:
URL: https://github.com/apache/lucene/pull/15936#discussion_r3295934755
##########
lucene/grouping/src/test/org/apache/lucene/search/grouping/TestBlockGrouping.java:
##########
@@ -77,6 +77,64 @@ public void testSimple() throws IOException {
shard.close();
}
+ public void testShardedBlockGrouping() throws IOException {
Review Comment:
This test verifies that the result is consistent between a single collector
manager and one collector manager per shard, it was inspired by
https://github.com/apache/lucene/blob/9c957f8a2c6dea79e834b308ec2288d999f5acbd/lucene/grouping/src/test/org/apache/lucene/search/grouping/BaseGroupSelectorTestCase.java#L272.
That's true that we are testing search concurrency on the existing tests
because they're using GroupingSearch class and we changed the code from
collector to collector manager in that class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
