javanna commented on PR #16133: URL: https://github.com/apache/lucene/pull/16133#issuecomment-4611011414
I was reminded of previous discussions about the pattern to follow in Filter* classes, as mentioned in #15469 and other related conversations. Given `competitiveIterator` is a default method and not abstract, perhaps we should leave this as-is, and instead correct the subclasses that need to override it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
