mrkm4ntr commented on PR #16133: URL: https://github.com/apache/lucene/pull/16133#issuecomment-4665971116
That's an interesting direction for a future major version. Making these default implementations non-default would indeed eliminate the ambiguity around what Filter* classes should delegate. That said, I think it's out of scope for this PR. Under the current design, FilterLeafCollector is a delegator that already delegates setScorer(), collect(), and finish() — adding competitiveIterator() is consistent with that role. I'd prefer to keep this fix in FilterLeafCollector for now, and the broader interface design discussion can be tracked separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
