iprithv commented on PR #16316: URL: https://github.com/apache/lucene/pull/16316#issuecomment-4854474132
thanks for the fix, @romseygeek. Apologies.. this regression was introduced in #15971, where I replaced the cardinality() call with growNoCopy(INNER_WINDOW_SIZE) directly in the MaxScoreBulkScorer constructor to avoid a redundant bitset pass. while that helped the hot multi-essential-clause path, it caused unnecessary eager allocation of the large DocAndScoreAccBuffer arrays in many other cases (especially boolean queries with expensive two-phase subclauses, which affected some percolator queries). I see that you have restored lazy allocation for the buffer while preserving the performance benefit. thanks again...Tagging #15971 for traceability. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
