donnerpeter commented on code in PR #16359:
URL: https://github.com/apache/lucene/pull/16359#discussion_r3527994949
##########
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/DictionarySuggester.java:
##########
@@ -0,0 +1,14 @@
+package org.apache.lucene.analysis.hunspell;
+
+import java.util.List;
+import java.util.Set;
+
+/** A class that traverses the dictionary to generate the suggestions */
+public interface DictionarySuggester {
+
+ DictionarySuggester withSpeller(Hunspell hunspell);
+
+ DictionarySuggester withCache(SuggestibleEntryCache cache);
Review Comment:
These seem optional from this signature, yet they're in fact required. I'd
make that explicit, e.g. by passing them to `suggest` as parameters. And add
some Javadoc to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
