donnerpeter commented on code in PR #16359:
URL: https://github.com/apache/lucene/pull/16359#discussion_r3528774880
##########
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/GeneratingSuggester.java:
##########
@@ -45,13 +45,29 @@ class GeneratingSuggester {
private final Hunspell speller;
private final SuggestibleEntryCache entryCache;
- GeneratingSuggester(Hunspell speller, SuggestibleEntryCache entryCache) {
- this.dictionary = speller.dictionary;
+ GeneratingSuggester() {
Review Comment:
Smelly. Maybe another, small class should implement `DictionarySuggester`?
E.g. smth like inner `GeneratingSuggester.Provider`? Or even a lambda directly
in `Suggester`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
