msokolov commented on PR #16411: URL: https://github.com/apache/lucene/pull/16411#issuecomment-5091037347
It makes sense; I have two slight concerns/questions: (1) we are adding some small cost in a hot spot that usually doesn't help. I assume it's small enough not to worry, but it would be good to domenstrate with benchmarks since this is supposed to be a performance improvement. (2) Can the approach be extended to the case where there is only a single value for every document in the segment (not missing), or the case where all docs in the queue have missing value and we are sorting missing first? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
