msfroh commented on code in PR #16173:
URL: https://github.com/apache/lucene/pull/16173#discussion_r3724441919
##########
lucene/core/src/test/org/apache/lucene/store/TestFilterDirectory.java:
##########
@@ -45,6 +42,21 @@ public void testOverrides() throws Exception {
}
}
+ public void testCopyFromDelegates() throws IOException {
Review Comment:
This does run the linked code, but it doesn't verify the changed behavior.
If you revert your change to `FilterDirectory`, this test will still pass.
(I just confirmed that by copying the test, but not the delegation.)
##########
lucene/core/src/test/org/apache/lucene/store/TestFilterDirectory.java:
##########
@@ -45,6 +42,21 @@ public void testOverrides() throws Exception {
}
}
+ public void testCopyFromDelegates() throws IOException {
Review Comment:
This does run the delegation code, but it doesn't verify the changed
behavior.
If you revert your change to `FilterDirectory`, this test will still pass.
(I just confirmed that by copying the test, but not the delegation.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
