dweiss commented on PR #16543: URL: https://github.com/apache/lucene/pull/16543#issuecomment-5374277685
In short, it is similar but not the same. It is different enough that I thought I'd file a separate PR instead of pushing to your branch (but I can, it's up to you). I wanted to keep this thing entirely separate (so that no extra stuff needs to go into gradle-wrapper.properties, for example) and optional (so that unless you specify those env properties, nothing changes for anybody else). The logic we have now works fine for many people and it's a result of multiple iterations of changes, I don't think we should change it, to be honest. So everything related to this "intranet-mirror" is self-contained in a single, separate class. Also, contrary to your patch, this one simulates gradle wrapper's logic pretty closely - including the same lock files, sha checksums matching the "official" distribution and a separate variable for fetching both the wrapper and the distribution code. I initially made some shortcuts (launched gradle directly, without gradle-wrapper.jar) but it wasn't good - there are manifest entries in gradle-wrapper.jar that would have to be passed to the bootstrap class (Enable-Native-Access: ALL-UNNAMED)... it was way more complicated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
