dweiss commented on PR #16543: URL: https://github.com/apache/lucene/pull/16543#issuecomment-5408158546
> Keeping an edited gradle-wrapper.properties with a corporate distributionUrl hasn't been too annoying to maintain. I'm sorry but I disagree with you here. This file is outside of Lucene's control, it shouldn't be modified. When upstream changes gradle version you'll get conflicts on any pull/merge. It seems weird to accept it. > The wrapper is not paired with the distribution requiring version alignment. Of course it is - that's why they publish SHA checksums for each and every release: https://gradle.org/release-checksums/ It may not *change* from version to version but each version expects its aligned wrapper. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
