sgup432 commented on PR #16540: URL: https://github.com/apache/lucene/pull/16540#issuecomment-5483283289
> wanted to check if this was a conscious tradeoff and if there's any data assessing the impact. Yeah it was a conscious choice as I took the idea mentioned here(https://github.com/apache/lucene/pull/16358) for this one as well. In a nutshell, the idea was to make the layout format more flexible and the reader can use the entry size and typed prefix to skip over it. Also it makes introducing newer changes(like adding more metadata to this structure) much easier. Note that this is in draft state, as I wanted to verify few more things and add more tests. I will convert this into non-draft soon. >the skip index file uses FileTypeHint.INDEX but this PR uses FileTypeHint.DATA Good point. And yes we should use `FileTypeHint.INDEX` now considering we storing this in a separate file. I will make this change as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
