epotyom commented on PR #16446: URL: https://github.com/apache/lucene/pull/16446#issuecomment-5508817276
> However, I’m seeing a number of existing tests failing as a result of the modification. Are you seeing the same failures? If so, do you think those failures are expected behavior changes, or is there something else I’m missing? Confirming there are other test failures, but I believe they are "cosmetic" as in they produce exactly same results as well as IndexSearcher.rewrite likely erases the difference before query is executed. For example: ``` Expected :motley crue motl* cru* Actual :(motley crue) motl* cru* ``` first is flat BooleanQuery with 4 should clauses, second is 2 level BooleanQuery, but first clause is a BQ with two should clauses, so https://github.com/apache/lucene/blob/54283150a8160779b2c86201af75b9126acc061b/lucene/core/src/java/org/apache/lucene/search/BooleanQuery.java#L496 flattens it before query exec. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
