epotyom commented on PR #16446: URL: https://github.com/apache/lucene/pull/16446#issuecomment-5512476314
My commit is based on this PR, I think we should keep it. As for https://github.com/apache/lucene/pull/16442 , it has great new tests that uncover the issue, so I'd suggest you iterate on it and change it to use addClause, regenerate query parser classes and update the tests (add test from my commit and fix cosmetic assert failures). WDYT? Let me know if prefer to split it somehow - but it could be tricky as ideally we ship unit tests together with the fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
