kkewwei commented on code in PR #16515:
URL: https://github.com/apache/lucene/pull/16515#discussion_r3934499590
##########
lucene/core/src/test/org/apache/lucene/search/TestMaxScoreBulkScorer.java:
##########
@@ -1446,6 +1482,14 @@ public float getMaxScore(int upTo) throws IOException {
minGetMaxScoreUpTo[0] = Math.min(minGetMaxScoreUpTo[0],
upTo);
return in.getMaxScore(upTo);
}
+
+ @Override
+ public void nextDocsAndScores(
+ int upTo, Bits liveDocs, DocAndFloatFeatureBuffer buffer)
throws IOException {
+ in.nextDocsAndScores(upTo, liveDocs, buffer);
+ scoredDocs[0] += buffer.size;
+ nextDocsAndScoresCalls[0]++;
Review Comment:
You're right. I've updated the test to verify that `liveDocs` matches the
`expectedLiveDocs`. I also kept the scored-doc count assertion to ensure that
filtered documents are not scored. Thanks for the careful and thorough review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
