kkewwei commented on PR #16515: URL: https://github.com/apache/lucene/pull/16515#issuecomment-5331188361
> I'm still doing benchmark, seems like perf drops when acceptDocs is null, but I'm not 100% sure yet. The int overflow caused the benchmark results to be highly misleading. In this `MaxScoreBulkScorerFilterBenchmark`, the aggregate SHOULD cost is approximately 30%+ of documents . Therefore, I benchmarked filter densities from 1% to 30%(`filterMatches` != null ) Results: | SHOULD clauses | Filter density | Baseline ops/ms | Candidate ops/ms | Improvement | |---:|---:|---:|---:|---:| | 10 | 1% | 0.258 | 0.669 | +159.9% | | 10 | 5% | 0.202 | 0.431 | +113.3% | | 10 | 10% | 0.217 | 0.389 | +79.3% | | 10 | 20% | 0.229 | 0.313 | +36.4% | | 10 | 30% | 0.204 | 0.311 | +52.2% | | 20 | 1% | 0.159 | 0.425 | +167.5% | | 20 | 5% | 0.150 | 0.299 | +99.1% | | 20 | 10% | 0.147 | 0.280 | +90.2% | | 20 | 20% | 0.149 | 0.233 | +56.5% | | 20 | 30% | 0.142 | 0.207 | +45.9% | The change improves throughput across all tested configurations, by 36% to 167%. As expected, the largest gains are with sparse filters, where more candidate documents can be discarded before score. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
