john-mlika commented on PR #16665: URL: https://github.com/apache/lucene/pull/16665#issuecomment-5679228800
thanks for the benchmark @kaivalnp! i caught this issue while working on a followup for #15732. the follow up is to remove the readback that happens on the merged .vec for producing query side quantized vectors (in case of asymmetric quantization) while testing the followup, i came across this when merging some randomly generated vectors (which weren't normalized) which triggered the quantizer's unit vector assertion for COSINE -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
