msokolov commented on PR #16665: URL: https://github.com/apache/lucene/pull/16665#issuecomment-5733139105
_My_ preference would be to deprecate COSINE altogether since it is really just a trap. Normalize your own vectors, or else use MAX_INNER_PRODUCT/ I agree we should fix the bugs in the published implementation, but instead of doubling down on this monstrosity by adding normalization code, can we mark as @Deprecated and remove in 11.0? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
