thecoop commented on code in PR #16696:
URL: https://github.com/apache/lucene/pull/16696#discussion_r4073155518
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene104/Lucene104ScalarQuantizedVectorsWriter.java:
##########
@@ -371,26 +371,52 @@ private QuantizedFloatVectorValues quantizeFromFloats(
}
@Override
- public void mergeOneFlatVectorField(FieldInfo fieldInfo, MergeState
mergeState)
+ public final void mergeOneFlatVectorField(FieldInfo fieldInfo, MergeState
mergeState)
+ throws IOException {
+ mergeOneFlatVectorField(fieldInfo, mergeState, _ -> false);
Review Comment:
This calls the new private method, so is not overridable at all in
subclasses - this is an interface change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
