john-mlika commented on code in PR #16696:
URL: https://github.com/apache/lucene/pull/16696#discussion_r4077977121
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene104/Lucene104ScalarQuantizedVectorsWriter.java:
##########
@@ -371,26 +371,52 @@ private QuantizedFloatVectorValues quantizeFromFloats(
}
@Override
- public void mergeOneFlatVectorField(FieldInfo fieldInfo, MergeState
mergeState)
+ public final void mergeOneFlatVectorField(FieldInfo fieldInfo, MergeState
mergeState)
+ throws IOException {
+ mergeOneFlatVectorField(fieldInfo, mergeState, _ -> false);
Review Comment:
the reasoning for final was:
- this class is experimental
- anything overriding the old method on the assumption that it changes HNSW
merges (which is not the case anymore) is better off getting a compile error
i dropped final though, the javadoc on the new method now says to override
mergeOneFlatVectorFieldForMergeScorer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
