rmuir commented on PR #16807: URL: https://github.com/apache/lucene/pull/16807#issuecomment-6098822087
> It's crazy the stuff we have to do to get the computers to do their job right! We've seen this before with hotspot where the wrong branch gets optimized due to the order in which code is run, but we keep wanting to DRY up to make things more readable. It's sad we can't have both. I won't be able to do a careful review for a week or so, but the general observation here makes sense to me. Yeah, but I'd add that with vector API (at least in the current state), we need to take special care. It runs fast if "all the stars align" and all the compiler optimizations do the right thing. But if not, then code tends to execute like 30x slower than even a simple scalar version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
