rmuir commented on PR #16807: URL: https://github.com/apache/lucene/pull/16807#issuecomment-6099210056
IMO best way would be to add a JMH for the vectorutil stuff that tries to pollute as much as possible. If there's a bug then the tests run extremely slow, and we can think about any other automation from there :) Most abstractions in use are static final, but there are some abstractions such as ByteVectorLoader in the shared methods that could cause trouble. It only has two implementations, so inlining should still work as long as nobody adds a third. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
