kkewwei commented on code in PR #16832:
URL: https://github.com/apache/lucene/pull/16832#discussion_r4313284630
##########
lucene/core/src/test/org/apache/lucene/codecs/lucene90/TestLucene90DocValuesFormat.java:
##########
@@ -1394,4 +1396,65 @@ public IndexInput slice(String sliceDescription, long
offset, long length) {
}
}
}
+
+ public void testReuseAddressUpper() throws Exception {
Review Comment:
Thank you for the review.
Yes, that's correct: the test also passes without my changes. I added it
only to verify that the code still behaves correctly after the change. Since
the behavior is likely covered by existing tests, I agree that the test doesn't
have much value, and I'll remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
