[
https://issues.apache.org/jira/browse/CLOWNFISH-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14679486#comment-14679486
]
ASF GitHub Bot commented on CLOWNFISH-59:
-----------------------------------------
GitHub user rectang opened a pull request:
https://github.com/apache/lucy-clownfish/pull/33
CLOWNFISH-59 Refine go other types
Refine the Go bindings for Class, Method, CharBuf, ByteBuf and
StringIterator and add tests.
This branch also changes ByteBuf's `Cat()` to take a Blob rather than
another ByteBuf, similar to how CharBuf's `Cat()` takes a String.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rectang/lucy-clownfish
CLOWNFISH-59-refine-go-other-types
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucy-clownfish/pull/33.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #33
----
commit 9f8face671530d662168a5482c5946397e5e7986
Author: Marvin Humphrey <[email protected]>
Date: 2015-08-07T21:31:35Z
Custom Go bindings for Class.
Add hand-coded binding for FetchClass. Override GetMethods to return
`[]Method` rather than `[]interface{}`.
commit 172822e62b8ce190dd58f5889bdce2185e037df2
Author: Marvin Humphrey <[email protected]>
Date: 2015-08-08T00:52:43Z
Tests for Class Go bindings.
commit e68fe4bda0d30a7659f744e9dabab297e1fb180d
Author: Marvin Humphrey <[email protected]>
Date: 2015-08-08T00:53:14Z
Implement Meth_Host_Name for Go.
Takes Upper_Snake_Case and removes the underscores.
commit 7073bd06c9ce58f83a910d78d9f665e268902069
Author: Marvin Humphrey <[email protected]>
Date: 2015-08-08T00:54:26Z
Tests for Method Go bindings.
commit f8c60c4fbb203a7b14548ed3d33bc39b812310f8
Author: Marvin Humphrey <[email protected]>
Date: 2015-08-08T01:02:31Z
Mark subroutines as unimplemented for Go.
* `Obj_To_Host`
* `Class_Foster_Obj`
* `Class_find_parent_class
commit a3ce8dd881b57cb9a9d4b63bc03c6da0f725076a
Author: Marvin Humphrey <[email protected]>
Date: 2015-08-08T01:22:55Z
Method ctor Go binding.
Accepts an `unsafe.Pointer` for the `cfish_method_t` implementing
function.
commit 647ef88ba585aa0b3802b4bf6952e26fa7008e68
Author: Marvin Humphrey <[email protected]>
Date: 2015-08-09T00:31:44Z
Custom Go binding for StrIter_new.
commit cd8ca2cfeabcfa7cce242f7be07250a6d1e90c14
Author: Marvin Humphrey <[email protected]>
Date: 2015-08-09T00:33:15Z
Tests for StringIterator Go bindings.
commit 7ef5eaf34d1caa8a3c6569599425da67ca5e26f0
Author: Marvin Humphrey <[email protected]>
Date: 2015-08-09T01:08:38Z
Tests for CharBuf Go bindings.
commit 26bb983745f01bc58e54e4717c3c31cfcb09c98d
Author: Marvin Humphrey <[email protected]>
Date: 2015-08-09T02:18:38Z
Change BB_Cat to take Blob arg.
This is analogous to having CharBuf's Cat take a String.
commit e1ae4b1309fccf6332fc82bb5f03615d3d34db5e
Author: Marvin Humphrey <[email protected]>
Date: 2015-08-09T02:19:41Z
Tests for ByteBuf Go bindings.
----
> Refine Go bindings
> ------------------
>
> Key: CLOWNFISH-59
> URL: https://issues.apache.org/jira/browse/CLOWNFISH-59
> Project: Apache Lucy-Clownfish
> Issue Type: Improvement
> Components: Go
> Reporter: Marvin Humphrey
> Assignee: Marvin Humphrey
> Fix For: 0.5.0
>
>
> The autogenerated Go bindings are usually good, but in some cases should be
> overridden. We also need tests for the Go bindings.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
