[
https://issues.apache.org/jira/browse/CLOWNFISH-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15073075#comment-15073075
]
ASF GitHub Bot commented on CLOWNFISH-59:
-----------------------------------------
GitHub user rectang opened a pull request:
https://github.com/apache/lucy-clownfish/pull/50
CLOWNFISH-59 Fixes for Go Err bindings
Fix a refcounting error and a non-polymorphic type conversion.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rectang/lucy-clownfish
CLOWNFISH-59-Go-Err-fixes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucy-clownfish/pull/50.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #50
----
commit fde1b7dbd5cf460342eb82f94fde071d2f032149
Author: Marvin Humphrey <[email protected]>
Date: 2015-12-24T00:31:37Z
Fix a missing refcount in the Go host error trapping.
Err_trap returns an `incremented` Err object, so we need to return an
incremented reference rather than return the pointer extracted from the
Err Go wrapper directly. If we don't do that, we're arming a time bomb
which will go off the first GC after the caller disposes of their
refcount.
commit aea2827d53879c2b819bb6e5bdd3444f758d0c51
Author: Marvin Humphrey <[email protected]>
Date: 2015-12-24T00:41:34Z
Use correct wrapper for Err subtypes.
Err subtypes need to be wrapped in their specificc Go structs, not just the
basic ErrIMP.
----
> Refine Go bindings
> ------------------
>
> Key: CLOWNFISH-59
> URL: https://issues.apache.org/jira/browse/CLOWNFISH-59
> Project: Apache Lucy-Clownfish
> Issue Type: Improvement
> Components: Go
> Reporter: Marvin Humphrey
> Assignee: Marvin Humphrey
> Fix For: 0.5.0
>
>
> The autogenerated Go bindings are usually good, but in some cases should be
> overridden. We also need tests for the Go bindings.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
