[ 
https://issues.apache.org/jira/browse/LUCY-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14946125#comment-14946125
 ] 

ASF GitHub Bot commented on LUCY-282:
-------------------------------------

GitHub user rectang opened a pull request:

    https://github.com/apache/lucy/pull/24

    LUCY-282 Test Go bindings for Analysis classes

    Refine and test the Go bindings for Token, Inversion and various Analyzers.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rectang/lucy LUCY-282-test-analysis-go

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucy/pull/24.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #24
    
----
commit 64156f43bc9b47c7e9cde954c34de5a9849a951b
Author: Marvin Humphrey <[email protected]>
Date:   2015-10-06T19:55:28Z

    Start new Go test file for Analysis.
    
    Create test_analysis.go.  Move a test.

commit 7dd69a6bbb82216da5dfb243c67c532af8c1c8df
Author: Marvin Humphrey <[email protected]>
Date:   2015-10-06T20:41:25Z

    Customize Go binding for Token.
    
    Hand-roll bindings for constructor, SetText, and GetText.  Add basic
    tests.

commit 4f7227e74b62e070dd1aae7e9c86b0cf388762dc
Author: Marvin Humphrey <[email protected]>
Date:   2015-10-06T22:59:13Z

    Test Go bindings for Inversion.

commit 094b76ebfd217278c40873cf4505344dc4c09e12
Author: Marvin Humphrey <[email protected]>
Date:   2015-10-07T01:41:58Z

    Customize Analyzer#Split for Go.
    
    Return a slice of strings rather than a slice of empty interface.

commit 51029f8f6b5ad7c0d848e20db900cac5339c0bdb
Author: Marvin Humphrey <[email protected]>
Date:   2015-10-07T01:42:58Z

    Test Go bindings for various Analyzers.

----


> Refine and test Go bindings
> ---------------------------
>
>                 Key: LUCY-282
>                 URL: https://issues.apache.org/jira/browse/LUCY-282
>             Project: Lucy
>          Issue Type: Improvement
>          Components: Go bindings
>            Reporter: Marvin Humphrey
>            Assignee: Marvin Humphrey
>             Fix For: 0.5.0
>
>
> Now that we have roughly useful automated Go bindings, work through them fine 
> tuning for Go idiomatic usage and writing tests to ensure the Go bindings 
> work as expected.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to