[
https://issues.apache.org/jira/browse/LUCY-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14979667#comment-14979667
]
ASF GitHub Bot commented on LUCY-282:
-------------------------------------
GitHub user rectang opened a pull request:
https://github.com/apache/lucy/pull/25
LUCY-282 Refine Go bindings for Store (IO) classes
Tune and test Go bindings for Store classes.
The Store (IO) classes for Lucy require a disproportionate number of
hand-coded method bindings because Clownfish yet doesn't have a way of
autogenerating idiomatic Go error handling, where non-fatal errors are returned
as part of a tuple return value instead of triggering exceptions.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rectang/lucy LUCY-282-test-store-go
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucy/pull/25.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #25
----
commit 0b2ceea35d0bef7f80a83610f1835235d507ebca
Author: Marvin Humphrey <[email protected]>
Date: 2015-10-08T01:25:48Z
Test RAMFile Go bindings.
commit dee4ee870694e7c33e89f0ecbc481730af291b5a
Author: Marvin Humphrey <[email protected]>
Date: 2015-10-09T01:20:30Z
Custom Go bindings for InStream/OutStream.
commit c7e96366a57662564cbaae6b6ef2d432f5d0f1c1
Author: Marvin Humphrey <[email protected]>
Date: 2015-10-21T01:22:20Z
Test Folder Go bindings.
commit c8950d0069a2714b3476f58026da9995624cf4b5
Author: Marvin Humphrey <[email protected]>
Date: 2015-10-21T02:04:43Z
Rework OpenOut for multi-value return.
The Go binding for Folder's OpenOut method should return a tuple of the
OutStream and an error.
commit b2a6e66680a09b6df82e2870c08510468e25f124
Author: Marvin Humphrey <[email protected]>
Date: 2015-10-21T21:38:37Z
Rework OpenIn for multi-value return.
The Go binding for Folder's OpenIn method should return a tuple of the
InStream and an error.
commit b3a0f3efa927ede9a6f7c8368916e9108feac293
Author: Marvin Humphrey <[email protected]>
Date: 2015-10-22T02:02:14Z
List_R and List may return NULL.
Specify that their return values are nullable in the method signature.
commit 5492483e447965ee64197df178f15e05bfa068ac
Author: Marvin Humphrey <[email protected]>
Date: 2015-10-21T22:21:06Z
Finish custom Go Bindings for Folder.
commit e00c88102d51c6fb427a986dce8082f47aa8c614
Author: Marvin Humphrey <[email protected]>
Date: 2015-10-22T02:09:17Z
Add helper converting Vector to slice of strings.
commit 5bd926fce657c2c9eb03677001859936db992d22
Author: Marvin Humphrey <[email protected]>
Date: 2015-10-27T02:02:51Z
Customize and test Go bindings for FileHandle.
commit 19ce9af135eacbb991284cb58dad35297d7f384d
Author: Marvin Humphrey <[email protected]>
Date: 2015-10-27T04:18:51Z
Customize DirHandle Go bindings.
commit bda80a7aebecaf716ba9b3145a5687d8989ec8b4
Author: Marvin Humphrey <[email protected]>
Date: 2015-10-28T02:24:51Z
Custom Go bindings for Lock.
commit a7f6c9f4f775f6378b216ba093eb5f3b1e3bc285
Author: Marvin Humphrey <[email protected]>
Date: 2015-10-28T02:37:08Z
Test Go bindings for LockFactory.
commit dd919892767b7d6a09cae2844c4d456aa332fef4
Author: Marvin Humphrey <[email protected]>
Date: 2015-10-28T03:11:33Z
Go bindings for CompoundFile[Reader/Writer].
----
> Refine and test Go bindings
> ---------------------------
>
> Key: LUCY-282
> URL: https://issues.apache.org/jira/browse/LUCY-282
> Project: Lucy
> Issue Type: Improvement
> Components: Go bindings
> Reporter: Marvin Humphrey
> Assignee: Marvin Humphrey
> Fix For: 0.5.0
>
>
> Now that we have roughly useful automated Go bindings, work through them fine
> tuning for Go idiomatic usage and writing tests to ensure the Go bindings
> work as expected.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
