[ 
https://issues.apache.org/jira/browse/MAHOUT-2096?focusedWorklogId=458880&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-458880
 ]

ASF GitHub Bot logged work on MAHOUT-2096:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Jul/20 19:10
            Start Date: 14/Jul/20 19:10
    Worklog Time Spent: 10m 
      Work Description: balashashanka commented on pull request #401:
URL: https://github.com/apache/mahout/pull/401#issuecomment-658360710


   Sure thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 458880)
    Time Spent: 0.5h  (was: 20m)

> next() Called On Possible Empty iterator()
> ------------------------------------------
>
>                 Key: MAHOUT-2096
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-2096
>             Project: Mahout
>          Issue Type: Bug
>          Components: Algorithms
>            Reporter: Shangru Li
>            Priority: Minor
>              Labels: easyfix, newbie
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Consider this function:
> {code}
>  protected void reduce ( VarIntWritable index, Iterable<VarLongWritable> ids, 
> Context
>    ctx) throws IOException, InterruptedException {
>      ctx.write(index, ids.iterator().next());
>  }
> {code}
> The line `_ctx.write(index, ids.iterator().next());_` does not check for 
> empty iterator when calling the next() function, which could result in an 
> exception.
> Function can be found on the GitHub repository 
> [here|https://github.com/apache/mahout/blob/754068bc3ac62bcf4b9b656cd4a6f413b29b18df/community/mahout-mr/mr/src/main/java/org/apache/mahout/cf/taste/hadoop/als/ParallelALSFactorizationJob.java#L395].
> Line 395, in file 
> _/src/main/java/org/apache/mahout/cf/taste/hadoop/als/ParallelALSFactorizationJob.java_



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to