[jira] [Work logged] (MAHOUT-2096) next() Called On Possible Empty iterator()

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/MAHOUT-2096?focusedWorklogId=901768&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-901768
 ]

ASF GitHub Bot logged work on MAHOUT-2096:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 25/Jan/24 18:06
            Start Date: 25/Jan/24 18:06
    Worklog Time Spent: 10m 
      Work Description: balashashanka commented on PR #401:
URL: https://github.com/apache/mahout/pull/401#issuecomment-1910729439

   Thanks and yes I would be interested in taking the maintainer role, but
   would need some help in initial days though
   
   *Regards*
     Shashanka Balakuntala Srinivasa
   
   
   
   On Thu, 25 Jan 2024 at 9:39 PM, Trevor Grant ***@***.***>
   wrote:
   
   > as it stands, this looks good to merge though
   >
   > —
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/mahout/pull/401#issuecomment-1910521421>, or
   > unsubscribe
   > 
<https://github.com/notifications/unsubscribe-auth/AFCZIJX5PZU7EGYQXEKDJHLYQJ7TZAVCNFSM4OZY7FU2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOJRGA2TEMJUGIYQ>
   > .
   > You are receiving this because you were mentioned.Message ID:
   > ***@***.***>
   >
   




Issue Time Tracking
-------------------

    Worklog Id:     (was: 901768)
    Time Spent: 1h  (was: 50m)

> next() Called On Possible Empty iterator()
> ------------------------------------------
>
>                 Key: MAHOUT-2096
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-2096
>             Project: Mahout
>          Issue Type: Bug
>          Components: Algorithms
>            Reporter: Shangru Li
>            Priority: Minor
>              Labels: easyfix, newbie
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> Consider this function:
> {code}
>  protected void reduce ( VarIntWritable index, Iterable<VarLongWritable> ids, 
> Context
>    ctx) throws IOException, InterruptedException {
>      ctx.write(index, ids.iterator().next());
>  }
> {code}
> The line `_ctx.write(index, ids.iterator().next());_` does not check for 
> empty iterator when calling the next() function, which could result in an 
> exception.
> Function can be found on the GitHub repository 
> [here|https://github.com/apache/mahout/blob/754068bc3ac62bcf4b9b656cd4a6f413b29b18df/community/mahout-mr/mr/src/main/java/org/apache/mahout/cf/taste/hadoop/als/ParallelALSFactorizationJob.java#L395].
> Line 395, in file 
> _/src/main/java/org/apache/mahout/cf/taste/hadoop/als/ParallelALSFactorizationJob.java_



--
This message was sent by Atlassian Jira
(v8.20.10#820010)