[
https://issues.apache.org/jira/browse/MAHOUT-878?focusedWorklogId=1000980&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1000980
]
ASF GitHub Bot logged work on MAHOUT-878:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Jan/26 12:28
Start Date: 20/Jan/26 12:28
Worklog Time Spent: 10m
Work Description: CheyuWu commented on code in PR #881:
URL: https://github.com/apache/mahout/pull/881#discussion_r2708146590
##########
qdp/qdp-python/src/lib.rs:
##########
@@ -152,7 +152,7 @@ fn is_pytorch_tensor(obj: &Bound<'_, PyAny>) ->
PyResult<bool> {
Ok(module_name == "torch")
}
-/// Helper to validate tensor
+/// Helper to validate CPU tensor
fn validate_tensor(tensor: &Bound<'_, PyAny>) -> PyResult<()> {
Review Comment:
Currently, `validate_tensor` is only called at this
[location](https://github.com/apache/mahout/pull/881/files#diff-2127e48c371dd5082474a4e975ac908065dc7b4a5736dfaa9f0efbfc95c8981aR535).
The only thing `validate_tensor` does is call `is_pytorch_tensor`.
Therefore, I don’t think it’s necessary to keep this function, since
`is_pytorch_tensor` has already been called earlier in
[here](https://github.com/apache/mahout/pull/881/files#diff-2127e48c371dd5082474a4e975ac908065dc7b4a5736dfaa9f0efbfc95c8981aR462).
Issue Time Tracking
-------------------
Worklog Id: (was: 1000980)
Time Spent: 2h 20m (was: 2h 10m)
> Provide better examples for the parallel ALS recommender code
> -------------------------------------------------------------
>
> Key: MAHOUT-878
> URL: https://issues.apache.org/jira/browse/MAHOUT-878
> Project: Mahout
> Issue Type: Task
> Affects Versions: 1.0.0
> Reporter: Sebastian Schelter
> Assignee: Sebastian Schelter
> Priority: Major
> Fix For: 0.6
>
> Attachments: MAHOUT-878.patch
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> We should provide examples that show how to apply the parallel ALS
> recommender to the Netflix or KDD2011 datasets.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
