[
https://issues.apache.org/jira/browse/MAHOUT-878?focusedWorklogId=1000990&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1000990
]
ASF GitHub Bot logged work on MAHOUT-878:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Jan/26 12:50
Start Date: 20/Jan/26 12:50
Worklog Time Spent: 10m
Work Description: ryankert01 commented on code in PR #881:
URL: https://github.com/apache/mahout/pull/881#discussion_r2708210622
##########
qdp/qdp-python/src/lib.rs:
##########
@@ -152,7 +152,7 @@ fn is_pytorch_tensor(obj: &Bound<'_, PyAny>) ->
PyResult<bool> {
Ok(module_name == "torch")
}
-/// Helper to validate tensor
+/// Helper to validate CPU tensor
fn validate_tensor(tensor: &Bound<'_, PyAny>) -> PyResult<()> {
Review Comment:
Good catch, got it!
In `validate_tensor` has a part of it redundant as it rechecks
`is_pytorch_tensor(tensor)`, but it can also catch other hardware tensor like
MPS, XLA, HPU, etc. if any.
We can refactor it and remove `is_pytorch_tensor(tensor)` as a followup. and
the function name probably should be renamed to `validate_tensor_cpu` or
something.
##########
qdp/qdp-python/src/lib.rs:
##########
@@ -152,7 +152,7 @@ fn is_pytorch_tensor(obj: &Bound<'_, PyAny>) ->
PyResult<bool> {
Ok(module_name == "torch")
}
-/// Helper to validate tensor
+/// Helper to validate CPU tensor
fn validate_tensor(tensor: &Bound<'_, PyAny>) -> PyResult<()> {
Review Comment:
Good catch, got it!
In `validate_tensor` has a part of it redundant as it rechecks
`is_pytorch_tensor(tensor)`, but it can also catch other hardware tensor like
MPS, XLA, HPU, etc. if any.
We can refactor it and remove `is_pytorch_tensor(tensor)` as a followup. and
the function name probably should be renamed to `validate_tensor_cpu` or
something.
Issue Time Tracking
-------------------
Worklog Id: (was: 1000990)
Time Spent: 3h 20m (was: 3h 10m)
> Provide better examples for the parallel ALS recommender code
> -------------------------------------------------------------
>
> Key: MAHOUT-878
> URL: https://issues.apache.org/jira/browse/MAHOUT-878
> Project: Mahout
> Issue Type: Task
> Affects Versions: 1.0.0
> Reporter: Sebastian Schelter
> Assignee: Sebastian Schelter
> Priority: Major
> Fix For: 0.6
>
> Attachments: MAHOUT-878.patch
>
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> We should provide examples that show how to apply the parallel ALS
> recommender to the Netflix or KDD2011 datasets.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
