[
https://issues.apache.org/jira/browse/MSHARED-495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15136701#comment-15136701
]
Hudson commented on MSHARED-495:
--------------------------------
SUCCESS: Integrated in maven-shared #851 (See
[https://builds.apache.org/job/maven-shared/851/])
[MSHARED-495] Add convenience method to move code into Maven Filtering
o Followup added missing test. (khmarbaise:
[http://svn.apache.org/viewvc/?view=rev&rev=1729093])
*
maven-filtering/src/test/java/org/apache/maven/shared/filtering/AbstractMavenFilteringRequestTest.java
[MSHARED-495] Add convenience method to move code into Maven Filtering
o Moving this code into maven-filtering makes changing the code
simpler and makes the plugins more independant. (khmarbaise:
[http://svn.apache.org/viewvc/?view=rev&rev=1729092])
* maven-filtering/pom.xml
*
maven-filtering/src/main/java/org/apache/maven/shared/filtering/AbstractMavenFilteringRequest.java
> Add convenience method to move code into Maven Filtering
> --------------------------------------------------------
>
> Key: MSHARED-495
> URL: https://issues.apache.org/jira/browse/MSHARED-495
> Project: Maven Shared Components
> Issue Type: Improvement
> Affects Versions: maven-filtering-3.0.0
> Reporter: Karl Heinz Marbaise
> Assignee: Karl Heinz Marbaise
> Priority: Minor
> Fix For: maven-filtering-3.1.0
>
>
> A few plugins contain the following code which belong into maven-filtering
> instead:
> {code:java}
> if ( delimiters != null && !delimiters.isEmpty() )
> {
> LinkedHashSet<String> delims = new LinkedHashSet<String>();
> if ( useDefaultDelimiters )
> {
> delims.addAll( this.getDelimiters() );
> }
> for ( String delim : delimiters )
> {
> if ( delim == null )
> {
> // FIXME: ${filter:*} could also trigger this condition.
> Need a better long-term solution.
> delims.add( "${*}" );
> }
> else
> {
> delims.add( delim );
> }
> }
> this.setDelimiters( delims );
> {code}
> Moving this code into maven-fitlering where it belongs. New method introduced:
> {code:java}
> setDelimiters( LinkedHashSet<String> delimiters, boolean useDefaultDelimiters
> )
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
