[ https://issues.apache.org/jira/browse/SUREFIRE-1254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15467324#comment-15467324 ]
ASF GitHub Bot commented on SUREFIRE-1254: ------------------------------------------ Github user Tibor17 commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/117#discussion_r77626386 --- Diff: surefire-logger-api/src/main/java/org/apache/maven/plugin/surefire/log/api/Level.java --- @@ -0,0 +1,83 @@ +package org.apache.maven.plugin.surefire.log.api; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/** + * Standard log levels, {@link #DEBUG} {@link #INFO} {@link #WARN} {@link #ERROR}, used in console. + * Test result levels {@link #FAILURE}, {@link #UNSTABLE}, {@link #SUCCESS}. + * Writing to console without color via {@link #NO_COLOR}. + * + * @author <a href="mailto:tibordig...@apache.org">Tibor Digana (tibor17)</a> + * @since 2.19.2 + */ +public enum Level { + /** + * call {@link ColoredConsoleMessageBuilder#toColorless(CharSequence)} + */ + NO_COLOR, + + /** + * defaults to bold, cyan + */ + DEBUG, + + /** + * defaults to bold, green + */ + INFO, + + /** + * defaults to bold, yellow + */ + WARN, + + /** + * defaults to bold, red + */ + ERROR, + + /** + * defaults to bold, green + */ + FAILURE, + + /** + * defaults to bold, yellow + */ + UNSTABLE, + + /** + * defaults to bold, red + */ + SUCCESS; + + public static Level resolveLevel(boolean hasSuccessful, boolean hasFailure, boolean hasError, + boolean hasSkipped, boolean hasFlake) { + boolean isRed = hasFailure | hasError; + if (isRed) { --- End diff -- yes, this has benn done - yet not committed. I am currently running build and one before last module failed `surefire-setup-integration-tests` because of wrong shading. The last module is `surefire-integration-tests` where I should switch off collors and then I have some activity to compare all binaries against binaries of previous release 2.19.1. Then I will run manual testing and compare console with old version and several features which alter the console like `rerun`, `assumptions` and reports. Maybe we should then test together. > add color messages > ------------------ > > Key: SUREFIRE-1254 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1254 > Project: Maven Surefire > Issue Type: New Feature > Components: Maven Failsafe Plugin, Maven Surefire Plugin > Reporter: Hervé Boutemy > Assignee: Tibor Digana > Fix For: 2.19.2 > > > with MNG-3507 fixed, adding colors to tests results would improve readability -- This message was sent by Atlassian JIRA (v6.3.4#6332)