ASF GitHub Bot commented on SUREFIRE-1254:

Github user Tibor17 commented on a diff in the pull request:

    --- Diff: 
    @@ -34,10 +34,11 @@
     import org.apache.maven.plugins.annotations.Mojo;
     import org.apache.maven.plugins.annotations.Parameter;
     import org.apache.maven.plugins.annotations.ResolutionScope;
    -import org.apache.maven.shared.utils.ReaderFactory;
     import org.apache.maven.shared.utils.StringUtils;
     import org.apache.maven.surefire.suite.RunResult;
    +import static org.apache.maven.shared.utils.ReaderFactory.FILE_ENCODING;
    --- End diff --
    I use it for several purposes. When line is getting to lone around 120 
characters and the constant is just a storage, or assertion statement when it 
is ugly to read the class; otherwise the whole statement is not verbal enough 
if class appears. I use IntelliJ IDEA which navigates me to the class where the 
constant is stored. I do not know how bout Eclipse abilities. I tried to use 
same name of method in static import and Java compiler failed, so it's safe 

> add color messages
> ------------------
>                 Key: SUREFIRE-1254
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1254
>             Project: Maven Surefire
>          Issue Type: Improvement
>          Components: Maven Failsafe Plugin, Maven Surefire Plugin, Maven 
> Surefire Report Plugin
>            Reporter: Hervé Boutemy
>            Assignee: Tibor Digana
>             Fix For: 2.19.2
> with MNG-3507 fixed, adding colors to tests results would improve readability

This message was sent by Atlassian JIRA

Reply via email to