ASF GitHub Bot commented on SUREFIRE-1293:

Github user Tibor17 commented on the issue:

    I fixed this issue where I removed [1]. The reason behind is the 
`IsolatedClassLoader` in plugin process which did not have shaded 
`commons-lang3` in original jar file of `surefire-common`. Because of one 
method in `commons-lang3` we should not pass such a big library. Instead I 
created `ObjectUtils` which has only few method and most of them is already in 
Java 7 utility class `java.util.Objects`. In Surefire on the top of Java 7 I 
will delete them and use Java 7 facilities.
    [1] import static org.apache.commons.lang3.ObjectUtils.defaultIfNull;

> Simplify org.apache.maven.plugin.surefire.report.TestSetRunListener by using 
> the null object pattern
> ----------------------------------------------------------------------------------------------------
>                 Key: SUREFIRE-1293
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1293
>             Project: Maven Surefire
>          Issue Type: Improvement
>          Components: Maven Surefire Plugin
>            Reporter: Benedikt Ritter
>            Assignee: Tibor Digana
>              Labels: github
>             Fix For: 2.19.2
> The class org.apache.maven.plugin.surefire.report.TestSetRunListener has a 
> lot of checks like this:
> {code:java}
> if( field != null )
> {
>     // do something with field
> }
> {code}
> This can be simplified by providing fallback implementations for the fields 
> being used by TestSetRunListener.

This message was sent by Atlassian JIRA

Reply via email to